Warn if user is not using a supported platform #7381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7381 +/- ##
==========================================
+ Coverage 60.07% 60.23% +0.15%
==========================================
Files 419 419
Lines 30456 30649 +193
==========================================
+ Hits 18297 18461 +164
- Misses 9146 9154 +8
- Partials 3013 3034 +21 |
dv8silencer
changed the title
farazdagi
reviewed
Oct 1, 2020
farazdagi
reviewed
Oct 1, 2020
farazdagi
reviewed
Oct 1, 2020
farazdagi
suggested changes
Oct 1, 2020
farazdagi
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Early in the invocation of the clients, this PR will make it so that there is warn-level output if the user's platform is not supported.
Which issues(s) does this PR fix?
Fixes #5797
Other notes for review