-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add journald option for logger #7463
Conversation
Thanks @potuz ! |
Codecov Report
@@ Coverage Diff @@
## master #7463 +/- ##
==========================================
- Coverage 60.98% 60.62% -0.37%
==========================================
Files 428 427 -1
Lines 30714 30567 -147
==========================================
- Hits 18732 18532 -200
- Misses 8934 9016 +82
+ Partials 3048 3019 -29 |
⚡️ A tip worth 25.00000 DAI (25.0 USD @ $1.0/DAI) has been granted to @potuz for this issue from @prestonvanloon. ⚡️ The sender had the following public comments:
https://github.com/prysmaticlabs/prysm/pulls?q=is%3Apr+author%3Apotuz+ Nice work @potuz! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.
|
Second try to add a "journald" parameter for --log-journal, without breaking compilation in Windows.
Fixes #7353
It's been reported to build on Windows and all test passing on the CI