Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add journald option for logger #7463

Merged
merged 7 commits into from
Oct 14, 2020

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Oct 8, 2020

Second try to add a "journald" parameter for --log-journal, without breaking compilation in Windows.

Fixes #7353

It's been reported to build on Windows and all test passing on the CI

@potuz potuz requested a review from a team as a code owner October 8, 2020 02:27
prestonvanloon
prestonvanloon previously approved these changes Oct 9, 2020
@prestonvanloon
Copy link
Member

Thanks @potuz !

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #7463 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7463      +/-   ##
==========================================
- Coverage   60.98%   60.62%   -0.37%     
==========================================
  Files         428      427       -1     
  Lines       30714    30567     -147     
==========================================
- Hits        18732    18532     -200     
- Misses       8934     9016      +82     
+ Partials     3048     3019      -29     

prestonvanloon
prestonvanloon previously approved these changes Oct 9, 2020
@gitcoinbot
Copy link

⚡️ A tip worth 25.00000 DAI (25.0 USD @ $1.0/DAI) has been granted to @potuz for this issue from @prestonvanloon. ⚡️

The sender had the following public comments:

Thanks for adding journald logging support and resolving breaking issues for windows quickly.

https://github.com/prysmaticlabs/prysm/pulls?q=is%3Apr+author%3Apotuz+

Nice work @potuz! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 88083d1 into prysmaticlabs:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use journald loglevel on Linux systems
3 participants