Numeric conversion cleanup #7465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 19b376e. # Conflicts: # beacon-chain/rpc/beacon/validators.go
This reverts commit f4acd6e.
This reverts commit 2a5c9ee.
This reverts commit 2863f9c.
This reverts commit 6e8385f.
This reverts commit c64a153.
This reverts commit fe773b5.
This reverts commit 7a0931c.
# Conflicts: # beacon-chain/powchain/log_processing.go
This reverts commit 8b34137.
Codecov Report
@@ Coverage Diff @@
## master #7465 +/- ##
=======================================
Coverage 60.74% 60.74%
=======================================
Files 427 427
Lines 30385 30385
=======================================
Hits 18458 18458
Misses 8940 8940
Partials 2987 2987 |
|
Deepsource is still complaining that there are new issues introduced. Can you please take a look? |
beacon-chain/powchain/service.go
Outdated
| @@ -722,6 +722,6 @@ func (s *Service) logTillChainStart() { | |||
|
|
|||
| log.WithFields(logrus.Fields{ | |||
| "Extra validators needed": valNeeded, | |||
| "Time till minimum genesis": fmt.Sprintf("%s", time.Duration(secondsLeft)*time.Second), | |||
| "Time till minimum genesis": fmt.Sprint((time.Duration(secondsLeft) * time.Second).String()), | |||
I don't think these are really new issues. Maybe nobody has touched these packages since we introduced DeepSource into the pipeline? Anyway, the only issues left are:
For (1) we have #6891. As for (2), this was already discussed on Discord and this "anti-pattern" seems to be a fairly standard Go pattern. I spoke about this with Nishant and Victor some time ago. We should confirm this and maybe configure the tool to ignore it? |
prestonvanloon
previously approved these changes
Oct 12, 2020
# Conflicts: # validator/keymanager/v2/derived/deposit_test.go
# Conflicts: # beacon-chain/powchain/service.go # beacon-chain/rpc/validator/proposer_test.go
farazdagi
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
Simplify/organize numeric conversions.
uint64()int64()uint()int()Which issues(s) does this PR fix?
N/A
Other notes for review
N/A