Resolve Web UI Beta Testing Bugs #7471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Oct 9, 2020
rauljordan
commented
Oct 9, 2020
| DepositDataResponse accounts_created = 2; | ||
| } | ||
|
|
||
| message DefaultWalletResponse { |
There was a problem hiding this comment.
Is a new message required? This looks like WalletResponse.
| @@ -18,6 +18,11 @@ service Wallet { | |||
| body: "*" | |||
| }; | |||
| } | |||
| rpc DefaultWalletPath(google.protobuf.Empty) returns (DefaultWalletResponse) { | |||
There was a problem hiding this comment.
Suggested change
| rpc DefaultWalletPath(google.protobuf.Empty) returns (DefaultWalletResponse) { | |
| rpc DefaultWallet(google.protobuf.Empty) returns (WalletResponse) { |
I think the "Path" part doesn't align with the path. Also, can you use WalletResponse?
That seems to make more sense to me.
| @@ -18,6 +18,11 @@ service Wallet { | |||
| body: "*" | |||
| }; | |||
| } | |||
| rpc DefaultWalletPath(google.protobuf.Empty) returns (DefaultWalletResponse) { | |||
| option (google.api.http) = { | |||
| get: "/v2/validator/wallet/default", | |||
There was a problem hiding this comment.
Suggested change
| get: "/v2/validator/wallet/default", | |
| get: "/v2/validator/wallet/config/default", |
Recommend: add config to the path for clarity.
I was thinking that /v2/validator/wallet would return a default wallet, so the distinction wasn't very clear between those two API routes.
prestonvanloon
previously approved these changes
Oct 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #7471 +/- ##
=======================================
Coverage 61.11% 61.11%
=======================================
Files 427 427
Lines 31054 31054
=======================================
Hits 18979 18979
Misses 9023 9023
Partials 3052 3052 |
prestonvanloon
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Other notes for review
Diff large due to mocks