Fix pregenesis countdown msg wording #7477
Conversation
beacon-chain/powchain/service.go
Outdated
| "Extra validators needed": valNeeded, | ||
| "Time till minimum genesis": fmt.Sprintf("%s", time.Duration(secondsLeft)*time.Second), | ||
| "Extra validators needed": valNeeded, | ||
| "Time till eth1 threshold": fmt.Sprintf("%s", time.Duration(secondsLeft)*time.Second), |
There was a problem hiding this comment.
Eth1 threshold is not a time. I don't quite understand this
There was a problem hiding this comment.
There are two countdowns, and the first countdown with 'minimum genesis' was confusing for users(because of MIN_GENESIS_TIME).
|
Needs docs approval on the language. cc: @har00ga I personally find this more confusing because min genesis time is the nomenclature that we have been using since the beginning and other teams are using as well. |
|
But that's the thing that MIN_GENESIS_TIME from config is different from what the first countdown is about. Am I wrong on that? |
The "seconds left" counts to the minimum genesis time or the actual genesis time of the chain, whichever is greater. |
|
I see how it could be confusing when secondsLeft counts to the actual genesis time rather than the min genesis time. Perhaps we can rename to remove "minimum". I.e. "Time till genesis". @har00ga thoughts? |
👍 |
|
Agree with @bidlocode the message is confusing. Although |
|
Sounds good to me @nisdas |
…fix-pregenesis-logs-wording
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
@bidlocode Hey, are you planning on completing this PR? It was been marked as stale by the bot. |
…fix-pregenesis-logs-wording
Codecov Report
@@ Coverage Diff @@
## master #7477 +/- ##
==========================================
- Coverage 61.88% 61.88% -0.01%
==========================================
Files 422 422
Lines 29714 29721 +7
==========================================
+ Hits 18389 18392 +3
+ Misses 8404 8403 -1
- Partials 2921 2926 +5 |
Fixes #7476
Pre genesis countdown log messages might be confusing: