Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle voting ties in BestFinalized() #7622

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Handle voting ties in BestFinalized() #7622

merged 2 commits into from
Oct 23, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Another minor bug (sorry, should have spotted it in Fix BestFinalized method #7619)
  • Basically, if two (or more) epochs receive the same number of votes, then targetEpoch is not set to best/max finalized, but to arbitrary selected among those best scoring (we are looping using range, so whichever epoch comes first is selected).
  • This PR resolves it + adds regression test.

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi requested a review from a team as a code owner October 23, 2020 04:16
@farazdagi farazdagi self-assigned this Oct 23, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit e5e51e6 into master Oct 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the best-finalized-handle-ties branch October 23, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisdas nisdas nisdas approved these changes

@rauljordan rauljordan Awaiting requested review from rauljordan

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@terencechain terencechain Awaiting requested review from terencechain

Assignees

@farazdagi farazdagi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farazdagi @nisdas