Refactor Subnet Search #8048
Merged
Refactor Subnet Search #8048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // for a subnet. So that even in the event of poor peer | ||
| // connectivity, we can still broadcast an attestation. | ||
| func (s *Service) hasPeerWithSubnet(topic string) bool { | ||
| return len(s.pubsub.ListPeers(topic+s.Encoding().ProtocolSuffix())) >= 1 |
There was a problem hiding this comment.
I know this is the only way you can access this information, but i worry it will be expensive. We might want to add HasPeer(topic string) to libp2p-pubsub. Just a thought.
There was a problem hiding this comment.
Yeah good point, although the API isn't in our direct control and any proposed changes will take some time to be discussed/implemented upstream
beacon-chain/p2p/subnets.go
Outdated
Comment on lines
57
to
58
| go func() { | ||
| wg.Add(1) |
There was a problem hiding this comment.
Suggested change
| go func() { | |
| wg.Add(1) | |
| wg.Add(1) | |
| go func() { |
I think you need to add this outside of the anonymous function.
redblaze4209
previously approved these changes
Dec 6, 2020
prestonvanloon
previously approved these changes
Dec 7, 2020
…/geth-sharding into revampSubnetSearch
rauljordan
reviewed
Dec 10, 2020
beacon-chain/p2p/iterator.go
Outdated
|
|
||
| // filterNodes wraps an iterator such that Next only returns nodes for which | ||
| // the 'check' function returns true. This custom implementation also | ||
| // checks for context deadlines so that t |
There was a problem hiding this comment.
godoc incomplete. It would be nice to have an explanation for why we are writing a custom iterator in Prysm
beacon-chain/p2p/subnets.go
Outdated
| @@ -18,10 +17,14 @@ var attestationSubnetCount = params.BeaconNetworkConfig().AttestationSubnetCount | |||
|
|
|||
| var attSubnetEnrKey = params.BeaconNetworkConfig().AttSubnetKey | |||
|
|
|||
| const peersRequiredInSubnetSearch = 20 | |||
There was a problem hiding this comment.
Can this be a config parameter?
beacon-chain/p2p/subnets.go
Outdated
| @@ -18,10 +17,14 @@ var attestationSubnetCount = params.BeaconNetworkConfig().AttestationSubnetCount | |||
|
|
|||
| var attSubnetEnrKey = params.BeaconNetworkConfig().AttSubnetKey | |||
|
|
|||
| const peersRequiredInSubnetSearch = 20 | |||
prestonvanloon
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Improvement
What does this PR do? Why is it needed?
semantics behind it.
to multiple subnets, this is a saner way to approach filtering for more valid peers.
Which issues(s) does this PR fix?
Fixes #
Other notes for review