Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back disable slashing broadcast flag #8141

Merged
merged 6 commits into from
Jan 4, 2021

Conversation

shayzluf
Copy link
Contributor

Feature

What does this PR do? Why is it needed?
This pr reverts the deletion of disable slashing broadcast flag in #7533

@shayzluf shayzluf added the Discussion Simply a thread for talking about stuff label Dec 16, 2020
@shayzluf shayzluf requested a review from a team as a code owner December 16, 2020 23:39
@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale There hasn't been any activity here in some time... label Dec 25, 2020
@rauljordan rauljordan removed the Stale There hasn't been any activity here in some time... label Dec 28, 2020
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Makes sense to bring the the flag as long as it is disable by default

@prylabs-bulldozer prylabs-bulldozer bot merged commit 70da296 into develop Jan 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the resurrect_disable_broadcast_slashing branch January 4, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Simply a thread for talking about stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants