Implement ListPeers in the node API #8288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Jan 19, 2021
| } | ||
|
|
||
| // PeerCount retrieves retrieves number of known peers. | ||
| func (ns *Server) PeerCount(ctx context.Context, _ *ptypes.Empty) (*ethpb.PeerCountResponse, error) { |
There was a problem hiding this comment.
Side-effect of prysmaticlabs/ethereumapis#214 - I had to add this function to conform to the new proto definitions.
Codecov Report
@@ Coverage Diff @@
## develop #8288 +/- ##
==========================================
Coverage ? 57.12%
==========================================
Files ? 449
Lines ? 31524
Branches ? 0
==========================================
Hits ? 18007
Misses ? 10723
Partials ? 2794 |
rauljordan
previously approved these changes
Jan 20, 2021
rauljordan
approved these changes
Jan 20, 2021
72 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR implements Node API's
ListPeersmethod according to the spec: https://ethereum.github.io/eth2.0-APIs/#/Node/getPeersWhich issues(s) does this PR fix?
Part of #7510
Other notes for review
Currently
ethpb.PeersRequest'sStateandDirectionfields are string arrays. I would like them to beethpb.ConnectionStateandethpb.PeerDirectionarrays, respectively. I will test if this is possible once @0xKiwi's PR with v1 gateway code is merged. I added a new checkbox to #7510, so that it's not forgotten about.