Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test assertion that reads a package-level variable #8329

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Remove test assertion that reads a package-level variable #8329

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b7848a
remove checking value of shared variable
rkapka Jan 25, 2021
ee3c20f
fix deepsource compliant
rkapka Jan 25, 2021
ce76d8f
Merge branch 'develop' into fix-flaky-import-test
rauljordan Jan 25, 2021
f6fdf9c
Merge refs/heads/develop into fix-flaky-import-test
prylabs-bulldozer[bot] Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions validator/accounts/accounts_import_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,18 +103,6 @@ func TestImport_DuplicateKeys(t *testing.T) {
},
})
require.NoError(t, err)
keymanager, err := imported.NewKeymanager(
cliCtx.Context,
&imported.SetupConfig{
Wallet: w,
},
)
require.NoError(t, err)

// Make sure there are no accounts at the start.
accounts, err := keymanager.ValidatingAccountNames()
require.NoError(t, err)
assert.Equal(t, len(accounts), 0)

// Create a key and then copy it to create a duplicate
_, keystorePath := createKeystore(t, keysDir)
Expand All @@ -127,7 +115,7 @@ func TestImport_DuplicateKeys(t *testing.T) {

require.NoError(t, ImportAccountsCli(cliCtx))

w, err = wallet.OpenWallet(cliCtx.Context, &wallet.Config{
_, err = wallet.OpenWallet(cliCtx.Context, &wallet.Config{
WalletDir: walletDir,
WalletPassword: password,
})
Expand Down