Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce helper function for adding context metadata from gRPC headers #8354

Merged
merged 7 commits into from
Jan 28, 2021

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Jan 28, 2021

What type of PR is this?

Refactor

What does this PR do? Why is it needed?

#8334 includes adding gRPC headers to context metadata. This is basically the same code repeated for the 4th time in the repo. This PR:

  • introduces a new helper function in the grpcutils package that should be used moving forward
  • changes existing header manipulation code to use the new helper
  • does a small clean-up to the grpcutils package

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@rkapka rkapka requested a review from a team as a code owner January 28, 2021 13:08
@rkapka rkapka added the Cleanup Code health! label Jan 28, 2021
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@e677b19). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #8354   +/-   ##
==========================================
  Coverage           ?   57.81%           
==========================================
  Files              ?      457           
  Lines              ?    31990           
  Branches           ?        0           
==========================================
  Hits               ?    18496           
  Misses             ?    10664           
  Partials           ?     2830           

@rauljordan rauljordan merged commit d9c451d into develop Jan 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the grpc-headers-helper branch January 28, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants