Update bazelbuild/rules_go to 0.24.13 (preparing for go 1.16 upgrade) #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinglamb
changed the title
nisdas
requested changes
Feb 17, 2021
There was a problem hiding this comment.
You have to register the toolchain correctly too below:
go_register_toolchains(
go_version = "1.16",
nogo = "@//:nogo",
)Also go.mod needs to be updated to account for the new go version, and there are some breaking changes in v1.16 (deprecating of ioutil) that we have to patch in too. Also we will want to use the new embed directive in a few places.
|
@nisdas This PR is intended to just update the |
pinglamb
changed the title
terencechain
requested changes
Feb 17, 2021
prestonvanloon
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Looks good!
@terencechain this doesn't update go to 1.16 yet. That can come in another PR.
terencechain
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Update
rules_goto0.24.13which starts to support go 1.16. https://github.com/bazelbuild/rules_go/releases/tag/v0.24.13This is for preparing the go 1.16 upgrade. Further changes/PRs are needed.
Which issues(s) does this PR fix?
Other notes for review