Use Custom Type ValidatorIndex Across Prysm #8478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
rauljordan
reviewed
Feb 19, 2021
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
rkapka
reviewed
Feb 22, 2021
rkapka
reviewed
Feb 22, 2021
rkapka
reviewed
Feb 22, 2021
| @@ -24,8 +24,8 @@ type ReadOnlyDatabase interface { | |||
| GetLatestEpochDetected(ctx context.Context) (types.Epoch, error) | |||
|
|
|||
| // BlockHeader related methods. | |||
| BlockHeaders(ctx context.Context, slot types.Slot, validatorID uint64) ([]*ethpb.SignedBeaconBlockHeader, error) | |||
| HasBlockHeader(ctx context.Context, slot types.Slot, validatorID uint64) bool | |||
| BlockHeaders(ctx context.Context, slot types.Slot, validatorID types.ValidatorIndex) ([]*ethpb.SignedBeaconBlockHeader, error) | |||
There was a problem hiding this comment.
Can we change ID to index in this file's interfaces and in some other places? They are not really the same (what would be a validator ID anyway? it's public key?) and we use indexes here. This might be too big of a change for this PR, though.
There was a problem hiding this comment.
Also I wonder whether it would not be a braking change...
There was a problem hiding this comment.
it should indeed be validatorIdx or validatorIndex
There was a problem hiding this comment.
Sounds good. Will do that in the next PR. It seems out of scope for now
rkapka
reviewed
Feb 22, 2021
rauljordan
changed the title
rauljordan
reviewed
Feb 22, 2021
rauljordan
previously approved these changes
Feb 22, 2021
farazdagi
reviewed
Feb 22, 2021
farazdagi
reviewed
Feb 22, 2021
farazdagi
reviewed
Feb 22, 2021
farazdagi
reviewed
Feb 22, 2021
farazdagi
suggested changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Use eth2 type
ValidtorIndexacross PrysmWhich issues(s) does this PR fix?
Part of #8205
Other notes for review
N/A