Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DeepSSZEqual for tests #8484

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Use DeepSSZEqual for tests #8484

merged 2 commits into from
Feb 22, 2021

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Feb 20, 2021

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Makes testing happy for using standard go test. Fixes the following...

panic: interface conversion: interface {} is bitfield.Bitlist, not []uint8 [recovered]

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@ad9cd19). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #8484   +/-   ##
==========================================
  Coverage           ?   58.06%           
==========================================
  Files              ?      456           
  Lines              ?    32756           
  Branches           ?        0           
==========================================
  Hits               ?    19021           
  Misses             ?    10849           
  Partials           ?     2886           

Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! These failing tests annoyed me.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 09ddfae into develop Feb 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the use-deep-ssz branch February 22, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants