Use DeepSSZEqual to satisfy go tests #8499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
commented
Feb 23, 2021
| @@ -65,7 +66,7 @@ func TestRestore(t *testing.T) { | |||
| require.NoError(t, err) | |||
| headBlock, err := restoredDb.HeadBlock(ctx) | |||
| require.NoError(t, err) | |||
| assert.Equal(t, uint64(5000), headBlock.Block.Slot, "Restored database has incorrect data") | |||
| assert.Equal(t, types.Slot(5000), headBlock.Block.Slot, "Restored database has incorrect data") | |||
There was a problem hiding this comment.
@farazdagi not sure how this was passing for bazel
There was a problem hiding this comment.
That's really strange! Will look into it.
terencechain
commented
Feb 23, 2021
| @@ -152,6 +152,9 @@ func TestServer_ListBlocks_Genesis_MultiBlocks(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestServer_ListBlocks_Pagination(t *testing.T) { | |||
| params.UseMinimalConfig() | |||
There was a problem hiding this comment.
These tests should have been minimal to begin. Only reason they were passing is because bazel leaked minimal config to here
rauljordan
approved these changes
Feb 23, 2021
farazdagi
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Running go test pkg by pkg to get them to pass. This PR fixes
DeepSSZEqualUseMinimalConfigtypes.SlotWhich issues(s) does this PR fix?
N/A
Other notes for review
N/A