Implement ListPoolProposerSlashings and ListPoolVoluntaryExits in the beacon API #8508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #8508 +/- ##
==========================================
Coverage ? 58.14%
==========================================
Files ? 458
Lines ? 32813
Branches ? 0
==========================================
Hits ? 19080
Misses ? 10839
Partials ? 2894 |
beacon-chain/rpc/beaconv1/pool.go
Outdated
| if err != nil { | ||
| return nil, status.Errorf(codes.Internal, "Could not get head state: %v", err) | ||
| } | ||
| sourceSlashings := bs.SlashingsPool.PendingProposerSlashings(ctx, headState, true) |
There was a problem hiding this comment.
Suggested change
| sourceSlashings := bs.SlashingsPool.PendingProposerSlashings(ctx, headState, true) | |
| sourceSlashings := bs.SlashingsPool.PendingProposerSlashings(ctx, headState, true /* unlimited return slashings */) |
beacon-chain/rpc/beaconv1/pool.go
Outdated
| return nil, status.Errorf(codes.Internal, "Could not get head state: %v", err) | ||
| } | ||
|
|
||
| sourceExits := bs.VoluntaryExitsPool.PendingExits(headState, headState.Slot(), true) |
There was a problem hiding this comment.
Same. A comment after true will be nice
| @@ -93,3 +93,45 @@ func V1Alpha1AttSlashingToV1(v1alpha1Slashing *ethpb_alpha.AttesterSlashing) *et | |||
| Attestation_2: V1Alpha1IndexedAttToV1(v1alpha1Slashing.Attestation_2), | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Some tests for the new functions below this line?
There was a problem hiding this comment.
Yeah, the migration package doesn't have any tests... Would it be OK if I create a separate PR with tests for the whole package?
terencechain
approved these changes
Feb 24, 2021
72 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR implements beacon API's
ListPoolProposerSlashingsandListPoolVoluntaryExitsmethods according to the spec: https://ethereum.github.io/eth2.0-APIs/#/BeaconWhich issues(s) does this PR fix?
Part of #7510
Other notes for review
Very similar to #8492