Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Default Transport Option #8525

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Fix Default Transport Option #8525

merged 2 commits into from
Feb 26, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Feb 26, 2021

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

  • Fixes to only TCP transports and removes the default websocket option.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner February 26, 2021 08:37
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@b4648f1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #8525   +/-   ##
==========================================
  Coverage           ?   58.16%           
==========================================
  Files              ?      459           
  Lines              ?    32899           
  Branches           ?        0           
==========================================
  Hits               ?    19136           
  Misses             ?    10863           
  Partials           ?     2900           

@rkapka rkapka merged commit e39ce36 into develop Feb 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fixDefaults branch February 26, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants