Improves UTs coverage in shared/aggregation #8593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Mar 11, 2021
farazdagi
commented
Mar 11, 2021
Comment on lines
-82
to
-86
| if !allowOverlaps && solution.Coverage.Overlaps(*candidate.bits) { | ||
| // Overlapping candidates violate non-intersection invariant. | ||
| candidate.processed = true | ||
| continue | ||
| } |
There was a problem hiding this comment.
This code is redundant, as above (on line 74), we filter out overlapping candidates in:
// Score candidates against remaining bits.
// ***Filter out processed and overlapping (when disallowed).***
// Sort by score in a descending order.
mc.Candidates.score(remainingBits).filter(solution.Coverage, allowOverlaps).sort()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
80% -> 95%+)Which issues(s) does this PR fix?
N/A
Other notes for review