Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeaconState: Expose MarshalSSZ #8609

Merged
merged 1 commit into from
Mar 16, 2021
Merged

BeaconState: Expose MarshalSSZ #8609

merged 1 commit into from
Mar 16, 2021

Conversation

terencechain
Copy link
Member

What type of PR is this?

Feature

What does this PR do? Why is it needed?

It seems anti pattern to always have to do:

InnerStateUnsafe().MarshalSSZ()
CloneInnerState().MarshalSSZ()

Where we should just define the MarshalSSZ for beacon state and hide implementation detail

Which issues(s) does this PR fix?

N/A

Other notes for review

Discovered in #8584

@terencechain terencechain requested a review from a team as a code owner March 15, 2021 23:11
@terencechain terencechain self-assigned this Mar 15, 2021
@prylabs-bulldozer prylabs-bulldozer bot merged commit 9fea981 into develop Mar 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the state-marshal-ssz branch March 16, 2021 00:43
@terencechain terencechain mentioned this pull request Mar 21, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xKiwi 0xKiwi 0xKiwi approved these changes

@farazdagi farazdagi Awaiting requested review from farazdagi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@rkapka rkapka Awaiting requested review from rkapka

Assignees

@terencechain terencechain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @0xKiwi