Dynamic key reload for remote keymanager #8611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Mar 16, 2021
| @@ -24,7 +25,7 @@ import ( | |||
| func (v *validator) WaitForActivation(ctx context.Context, accountsChangedChan chan [][48]byte) error { | |||
| // Monitor the key manager for updates. | |||
| if accountsChangedChan == nil { | |||
| accountsChangedChan = make(chan [][48]byte) | |||
| accountsChangedChan = make(chan [][48]byte, 1) | |||
There was a problem hiding this comment.
This change is required to prevent a deadlock.
rkapka
commented
Mar 16, 2021
| @@ -100,7 +100,7 @@ func run(ctx context.Context, v iface.Validator) { | |||
| handleAssignmentError(err, headSlot) | |||
| } | |||
|
|
|||
| accountsChangedChan := make(chan [][48]byte) | |||
| accountsChangedChan := make(chan [][48]byte, 1) | |||
There was a problem hiding this comment.
This change is required to prevent a deadlock.
rkapka
commented
Mar 16, 2021
Comment on lines
+92
to
+93
| remoteKm, ok := v.keyManager.(remote.RemoteKeymanager) | ||
| if ok { |
There was a problem hiding this comment.
The diff here looks like a mess, but I basically moved all existing code into the else branch and implemented the if branch.
rauljordan
approved these changes
Mar 16, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Implements all scenarios for the remote keymanager outlined in https://docs.google.com/document/d/1fLdUi6AHQ5-wYOy6DCzW5JlLlq3VuI275-KoyEZ2Pmw/edit#heading=h.m87ybthlvflh. Because the keymanager does not have the ability to notify about key changes in real time, we check for new keys on every slot.
Which issues(s) does this PR fix?
Part of #8572
Other notes for review
I am not too happy about the type assertion and if/else branching inside
waitForActivation, but I couldn't find a better way of handling the remote keymanager. We can't use thecase <-accountsChangedChanbecause there is no external trigger which notifies about key changes, as is the case with other keymanager types.