Define BeaconState Core Type and Protobuf Definition #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
Enhancement
rauljordan
commented
Nov 20, 2018
| repeated SpecialRecord specials = 9; | ||
| } | ||
|
|
||
| message CrystallizedState { |
There was a problem hiding this comment.
We keep these in here for now until we are done with the refactor
proto/beacon/p2p/v1/types.proto
Outdated
| uint64 last_justified_slot = 6; | ||
| uint64 justified_streak = 7; | ||
| repeated ShardAndCommitteeArray shard_and_committees_for_slots = 8; | ||
| repeated uint64 persistent_committees = 9; |
proto/beacon/p2p/v1/types.proto
Outdated
| } | ||
|
|
||
| message ShardReassignmentRecord { | ||
| uint64 validator_index = 1; |
proto/beacon/p2p/v1/types.proto
Outdated
| repeated uint64 deposits_penalized_in_period = 12; | ||
| bytes validator_delta_hash_chain = 13; | ||
| uint64 current_exit_seq = 14; | ||
| google.protobuf.Timestamp genesis_time = 15; |
There was a problem hiding this comment.
genesis time should probably be uint64 or we have to do the translation again before ssz
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
==========================================
+ Coverage 73.43% 73.47% +0.04%
==========================================
Files 67 67
Lines 4370 4362 -8
==========================================
- Hits 3209 3205 -4
+ Misses 843 839 -4
Partials 318 318 |
terencechain
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #781
Description
Given the latest specification, there is now only a single state for the beacon chain called
BeaconState. We will be abandoning the split between the active and crystallized states and beginning a beacon node refactor by starting from defining the new state core type. This PR encompasses a basic Golang struct to represent the BeaconState as well as protobuf definitions for the underlying types. This PR also refactors the proto directory a bit, splitting type definitions into atypes.protofile and p2p message request/response types into amessages.protofile.