Introduce API StateFetcher #8639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # beacon-chain/rpc/beaconv1/state.go # beacon-chain/rpc/service.go # shared/testutil/state.go
terencechain
approved these changes
Mar 22, 2021
| @@ -0,0 +1,108 @@ | |||
| package statefetcher | |||
|
|
|||
There was a problem hiding this comment.
Optional:
Can name this file fetcher.go instead. The folder name is statefetcher which already implies state
Codecov Report
@@ Coverage Diff @@
## develop #8639 +/- ##
===========================================
+ Coverage 61.21% 61.29% +0.07%
===========================================
Files 493 494 +1
Lines 34296 34325 +29
===========================================
+ Hits 20996 21040 +44
+ Misses 10169 10152 -17
- Partials 3131 3133 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Extracted from #8631. This PR lays the groundwork for implementing the API endpoint. More concretely, I moved the state getter function into a separate package so that it's reusable between different gRPC servers. To avoid code duplication, I created a new StateFetcher type. It will be used by the beacon and debug servers.
Which issues(s) does this PR fix?
Part of #7510
Other notes for review
N/A