Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DB To P2P Service #8676

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Add DB To P2P Service #8676

merged 2 commits into from
Mar 26, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Mar 26, 2021

What type of PR is this?

Feature Addition

What does this PR do? Why is it needed?

  • Adds in a DB to our P2P Service. The main purpose is to allow our gossip scorer to properly tune the relevant parameters with active validator counts.
  • Add Unit test.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added Ready For Review Networking P2P related items labels Mar 26, 2021
@nisdas nisdas requested a review from a team as a code owner March 26, 2021 12:49
@rauljordan rauljordan merged commit 7f0c925 into develop Mar 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the addDBToP2p branch March 26, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@farazdagi farazdagi Awaiting requested review from farazdagi

@terencechain terencechain Awaiting requested review from terencechain

Assignees
No one assigned
Labels
Networking P2P related items
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisdas @rauljordan