Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E remove redundant test case #8680

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • Originally, this test was added to have the smallest possible e2e test case that has connectivity issues (it takes only 1.5-2 mins to run, but enough to discover the issues with connectivity).
  • However, now when we have connectivity issues resolved this test case is redundant, mainly because it doesn't do anything that is not done during our main e2e test case. So, while useful for debugging, having +2 mins to e2e run (w/o checking anything that is not already checked during our main test) seems to be a waste of resources.

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi self-assigned this Mar 28, 2021
@farazdagi farazdagi requested a review from a team as a code owner March 28, 2021 08:18
@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #8680 (a921bb2) into develop (5f2f53a) will decrease coverage by 0.07%.
The diff coverage is 10.00%.

@@             Coverage Diff             @@
##           develop    #8680      +/-   ##
===========================================
- Coverage    61.18%   61.10%   -0.08%     
===========================================
  Files          494      494              
  Lines        34363    34432      +69     
===========================================
+ Hits         21024    21040      +16     
- Misses       10195    10251      +56     
+ Partials      3144     3141       -3     

@prylabs-bulldozer prylabs-bulldozer bot merged commit e26dab8 into develop Mar 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the e2e-remove-redundant-test branch March 28, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants