Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip e2e test for previous implementation of slasher #8693

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other / Cleanup

What does this PR do? Why is it needed?

  • After discussion with Raul, we've concluded that the current e2e test for slasher should be skipped:
    • the implementation is to be replaced by the new in-beacon slasher developed in feature/slasher and to be released soon.
    • current test is flaky

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi self-assigned this Mar 31, 2021
@farazdagi farazdagi requested a review from a team as a code owner March 31, 2021 16:34
@prylabs-bulldozer prylabs-bulldozer bot merged commit 9afa304 into develop Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #8693 (78018a3) into develop (28e4a3b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #8693   +/-   ##
========================================
  Coverage    61.15%   61.16%           
========================================
  Files          498      498           
  Lines        34711    34713    +2     
========================================
+ Hits         21227    21231    +4     
+ Misses       10332    10327    -5     
- Partials      3152     3155    +3     

@delete-merged-branch delete-merged-branch bot deleted the skip-old-slasher-e2e-test branch March 31, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants