Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weak subjectivity period calculating helper #8695

Merged
merged 7 commits into from
Apr 1, 2021
Merged

Weak subjectivity period calculating helper #8695

merged 7 commits into from
Apr 1, 2021

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Mar 31, 2021 •
edited
Loading

What type of PR is this?

Feature

What does this PR do? Why is it needed?

  • implements ComputeWeakSubjectivityPeriod as defined in specs

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi self-assigned this Mar 31, 2021
@farazdagi farazdagi requested a review from a team as a code owner March 31, 2021 23:39
@farazdagi farazdagi marked this pull request as draft April 1, 2021 11:07
@farazdagi farazdagi marked this pull request as ready for review April 1, 2021 16:26
terencechain
terencechain approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prylabs-bulldozer prylabs-bulldozer bot merged commit acf17f9 into develop Apr 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the weak-subjectivity-period-helper branch April 1, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@rauljordan rauljordan Awaiting requested review from rauljordan

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

Assignees

@farazdagi farazdagi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farazdagi @terencechain