Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weak subjectivity minor refactoring #8715

Merged
merged 8 commits into from
Apr 6, 2021
Merged

Weak subjectivity minor refactoring #8715

merged 8 commits into from
Apr 6, 2021

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Apr 6, 2021 •
edited
Loading

What type of PR is this?

Other / Refactoring

What does this PR do? Why is it needed?

  • Instead of storing wsEpoch and wsBlockRoot in node separately, this PR combines them into a single attribute WeakSubjectivityCheckpt of type Checkpoint (which features both epoch and root)
  • Helper methods to parse incoming block_root:epoch_number has been moved into beacon-chain/core/helpers/weak_subjectivity.go: ParseWeakSubjectivityInputString() to keep WS related functionality close together. Test suite has been extended a bit.

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi self-assigned this Apr 6, 2021
@farazdagi farazdagi marked this pull request as ready for review April 6, 2021 12:26
@farazdagi farazdagi requested a review from a team as a code owner April 6, 2021 12:26
terencechain
terencechain approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 74d0134 into develop Apr 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the weak-subjectivity-minor-refactoring branch April 6, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@nisdas nisdas Awaiting requested review from nisdas

Assignees

@farazdagi farazdagi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farazdagi @terencechain @rauljordan