Refactor Casper Validators Into Core/Validators Stateless Package #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-casper-validator
…into refactor-casper-validator
…prysm into refactor-casper-validator
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
==========================================
+ Coverage 73.57% 73.59% +0.02%
==========================================
Files 67 67
Lines 4371 4367 -4
==========================================
- Hits 3216 3214 -2
+ Misses 837 835 -2
Partials 318 318 |
rauljordan
approved these changes
Nov 21, 2018
| ) | ||
|
|
||
| const bitsInByte = 8 | ||
|
|
||
| var log = logrus.WithField("prefix", "core/validators") |
There was a problem hiding this comment.
no need to add log here (we are keeping these packages stateless and no assumptions about where they'll be run. we can keep logs in services)
|
Just a small change and then it will be ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #781
Description
This PR extracts the validator functions into their own stateless, pure package within beacon-chain/core/validators/
Note: WIP. Building this on top of #870, not ready for review