Fix overriding network config in tests #8756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared/params/network_config.go
Outdated
| @@ -42,7 +42,7 @@ func BeaconNetworkConfig() *NetworkConfig { | |||
| // OverrideBeaconNetworkConfig will override the network | |||
| // config with the added argument. | |||
| func OverrideBeaconNetworkConfig(cfg *NetworkConfig) { | |||
| networkConfig = cfg.Copy() | |||
| networkConfig = cfg | |||
There was a problem hiding this comment.
In your description it says it's only for tests but this is not used only for tests
There was a problem hiding this comment.
You're right... Now I am not so sure about the safety of this change. On the other hand this will align the network config's setup with the beacon config, so it doesn't look risky.
There was a problem hiding this comment.
At the minimal we should test pyrmont or prater still works. Better see it breaking earlier than later
There was a problem hiding this comment.
Lets leave it as it is, is there any reason a Copy needs to be removed ?
Codecov Report
@@ Coverage Diff @@
## develop #8756 +/- ##
===========================================
+ Coverage 61.56% 61.63% +0.07%
===========================================
Files 509 509
Lines 34803 34803
===========================================
+ Hits 21426 21452 +26
+ Misses 10208 10177 -31
- Partials 3169 3174 +5 |
nisdas
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Tests
What does this PR do? Why is it needed?
Overriding the network config in tests does not work properly. Config values are not being reset after the test, which may cause tests to fail if they're not in the correct order. The same issue does not occur for the beacon config.
This PR modifies the network config's setup to make it identical with the beacon config.
Which issues(s) does this PR fix?
N/A
Other notes for review
N/A