Update specs comments

beacon-chain/blockchain/process_block.go

@@ -51,7 +51,8 @@ var initialSyncBlockCacheSize = uint64(2 * params.BeaconConfig().SlotsPerEpoch)
 //    assert get_ancestor(store, block.parent_root, finalized_slot) == store.finalized_checkpoint.root
 //
 //    # Check the block is valid and compute the post-state
-//    state = state_transition(pre_state, signed_block, True)
+//    state = pre_state.copy()
+//    state_transition(state, signed_block, True)
 //    # Add new block to the store
 //    store.blocks[hash_tree_root(block)] = block
 //    # Add new state for this block to the store

beacon-chain/core/state/transition_no_verify_sig.go

@@ -20,16 +20,22 @@ import (
 // it is used for performing a state transition as quickly as possible. This function also returns a signature
 // set of all signatures not verified, so that they can be stored and verified later.
 //
-// WARNING: This method does not validate any signatures in a block. This method also modifies the passed in state.
+// WARNING: This method does not validate any signatures (i.e. calling `state_transition()` with `validate_result=False`).
+// This method also modifies the passed in state.
 //
 // Spec pseudocode definition:
-//  def state_transition(state: BeaconState, block: BeaconBlock, validate_state_root: bool=False) -> BeaconState:
+//  def state_transition(state: BeaconState, signed_block: SignedBeaconBlock, validate_result: bool=True) -> None:
+//    block = signed_block.message
 //    # Process slots (including those with no blocks) since block
 //    process_slots(state, block.slot)
+//    # Verify signature
+//    if validate_result:
+//        assert verify_block_signature(state, signed_block)
 //    # Process block
 //    process_block(state, block)
-//    # Return post-state
-//    return state
+//    # Verify state root
+//    if validate_result:
+//        assert block.state_root == hash_tree_root(state)
 func ExecuteStateTransitionNoVerifyAnySig(
 	ctx context.Context,
 	state iface.BeaconState,
@@ -82,17 +88,22 @@ func ExecuteStateTransitionNoVerifyAnySig(
 // state root of the state for the block proposer to use.
 // This does not modify state.
 //
-// WARNING: This method does not validate any BLS signatures. This is used for proposer to compute
-// state root before proposing a new block, and this does not modify state.
+// WARNING: This method does not validate any BLS signatures (i.e. calling `state_transition()` with `validate_result=False`).
+// This is used for proposer to compute state root before proposing a new block, and this does not modify state.
 //
 // Spec pseudocode definition:
-//  def state_transition(state: BeaconState, block: BeaconBlock, validate_state_root: bool=False) -> BeaconState:
+//  def state_transition(state: BeaconState, signed_block: SignedBeaconBlock, validate_result: bool=True) -> None:
+//    block = signed_block.message
 //    # Process slots (including those with no blocks) since block
 //    process_slots(state, block.slot)
+//    # Verify signature
+//    if validate_result:
+//        assert verify_block_signature(state, signed_block)
 //    # Process block
 //    process_block(state, block)
-//    # Return post-state
-//    return state
+//    # Verify state root
+//    if validate_result:
+//        assert block.state_root == hash_tree_root(state)
 func CalculateStateRoot(
 	ctx context.Context,
 	state iface.BeaconState,
@@ -212,20 +223,16 @@ func ProcessBlockNoVerifyAnySig(
 //  def process_operations(state: BeaconState, body: BeaconBlockBody) -> None:
 //    # Verify that outstanding deposits are processed up to the maximum number of deposits
 //    assert len(body.deposits) == min(MAX_DEPOSITS, state.eth1_data.deposit_count - state.eth1_deposit_index)
-//    # Verify that there are no duplicate transfers
-//    assert len(body.transfers) == len(set(body.transfers))
 //
-//    all_operations = (
-//        (body.proposer_slashings, process_proposer_slashing),
-//        (body.attester_slashings, process_attester_slashing),
-//        (body.attestations, process_attestation),
-//        (body.deposits, process_deposit),
-//        (body.voluntary_exits, process_voluntary_exit),
-//        (body.transfers, process_transfer),
-//    )  # type: Sequence[Tuple[List, Callable]]
-//    for operations, function in all_operations:
+//    def for_ops(operations: Sequence[Any], fn: Callable[[BeaconState, Any], None]) -> None:
 //        for operation in operations:
-//            function(state, operation)
+//            fn(state, operation)
+//
+//    for_ops(body.proposer_slashings, process_proposer_slashing)
+//    for_ops(body.attester_slashings, process_attester_slashing)
+//    for_ops(body.attestations, process_attestation)
+//    for_ops(body.deposits, process_deposit)
+//    for_ops(body.voluntary_exits, process_voluntary_exit)
 func ProcessOperationsNoVerifyAttsSigs(
 	ctx context.Context,
 	state iface.BeaconState,