Refactor process operation function arguments #8767
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #8767 +/- ##
===========================================
- Coverage 60.54% 60.53% -0.01%
===========================================
Files 519 519
Lines 36262 36271 +9
===========================================
+ Hits 21954 21957 +3
Misses 11144 11144
- Partials 3164 3170 +6 |
| @@ -32,25 +32,33 @@ var processDepositsFunc = func(ctx context.Context, s iface.BeaconState, blk *et | |||
| return b.ProcessDeposits(ctx, s, blk.Block.Body.Deposits) | |||
| } | |||
| var processProposerSlashingFunc = func(ctx context.Context, s iface.BeaconState, blk *ethpb.SignedBeaconBlock) (iface.BeaconState, error) { | |||
| return b.ProcessProposerSlashings(ctx, s, blk, v.SlashValidator) | |||
There was a problem hiding this comment.
Previously, within processor function blk and blk.Body was checked for nilness. If there are code paths that depended on that check, we might end up with panics (this method is used for ProcessBlock() when going through processing pipeline, no extra checks there either).
NB: The processDepositsFunc() (above) doesn't check for block/body nilness, and we seem to be ok. So, if you absolutely sure that check was redundant, and we can have a pipeline items w/o it, please, feel free to dismiss the review. Otherwise, checks should be added to processAttesterSlashingFunc, processEth1DataFunc(), and processExitFunc()
There was a problem hiding this comment.
Better safe than sorry. I added VerifyNilBeaconBlock to ProcessBlock. Thanks!
Motivated by #8638
Refactor these arguments to take the actual object instead of versioned block. They can be reused for Altair.
ProcessBlockHeaderNoVerify:*ethpb.BeaconBlock->slot types.Slot, proposerIndex types.ValidatorIndex, parentRoot, bodyRoot []byteProcessEth1DataInBlock:*ethpb.SignedBeaconBlock->*ethpb.Eth1DataProcessRandaoNoVerify:*ethpb.BeaconBlockBody->[]byteProcessProposerSlashings:*ethpb.SignedBeaconBlock->[]*ethpb.ProposerSlashingProcessAttesterSlashings:*ethpb.SignedBeaconBlock->[]*ethpb.AttesterSlashingProcessVoluntaryExits:*ethpb.SignedBeaconBlock->[]*ethpb.SignedVoluntaryExitThis is the first part. Expect many parts.