Tests for beacon-chain/node/config.go
#8769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #8769 +/- ##
===========================================
+ Coverage 60.45% 60.48% +0.03%
===========================================
Files 517 517
Lines 36203 36203
===========================================
+ Hits 21887 21898 +11
- Misses 11142 11144 +2
+ Partials 3174 3161 -13 |
farazdagi
reviewed
Apr 15, 2021
beacon-chain/node/config_test.go
Outdated
| set.Uint64(flags.NetworkID.Name, 0, "") | ||
| set.String(flags.DepositContractFlag.Name, "", "") | ||
| require.NoError(t, set.Set(flags.ChainID.Name, strconv.Itoa(100))) | ||
| require.NoError(t, set.Set(flags.NetworkID.Name, strconv.Itoa(100))) |
There was a problem hiding this comment.
Ideally, we should use different values, when testing multiple setters. If internally, say due to copy/paste in getter, we will expose NetworkID in both getters, this error will go unnoticed, when we use the same setter value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Testing
What does this PR do? Why is it needed?
Adds tests for the
beacon-chain/node/config.gofile.Which issues(s) does this PR fix?
N/A
Other notes for review
N/A