Update Go-Ethereum Dependency #8788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
Apr 19, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8788 +/- ##
===========================================
+ Coverage 60.49% 60.53% +0.04%
===========================================
Files 519 519
Lines 36290 36290
===========================================
+ Hits 21954 21969 +15
+ Misses 11166 11150 -16
- Partials 3170 3171 +1 |
terencechain
approved these changes
Apr 20, 2021
| @@ -57,7 +57,7 @@ func (node *Eth1Node) Start(ctx context.Context) error { | |||
| return errors.New("go-ethereum binary not found") | |||
| } | |||
|
|
|||
| eth1Path := path.Join(e2e.TestParams.TestPath, "eth1data/") | |||
| eth1Path := path.Join(e2e.TestParams.LogPath, "eth1data/") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR updates our bazel-go-ethereum dep to use the latest version, which contains the latest master branch of go-ethereum including some key additions to the eth1 <> eth2 merge specification.