Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec tests #8792

Merged
merged 15 commits into from
Apr 20, 2021
Merged

Update spec tests #8792

merged 15 commits into from
Apr 20, 2021

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Apr 20, 2021

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • Updates spec tests to the v1.0.1-alpha3 (output format for test generators has changed, instead of ssz+yaml outputs, everything is now dumped as ssz_snappy).
  • epoch_processing/final_updates has been split into several tests (specs comments have been updated in Refactor ProcessFinalUpdates(), per updated specs #8724, and within this PR, corresponding spec tests are updated).

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi self-assigned this Apr 20, 2021
@farazdagi farazdagi marked this pull request as ready for review April 20, 2021 23:35
@farazdagi farazdagi requested a review from a team as a code owner April 20, 2021 23:35
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #8792 (88374d6) into develop (711f527) will increase coverage by 0.04%.
The diff coverage is 76.47%.

@@             Coverage Diff             @@
##           develop    #8792      +/-   ##
===========================================
+ Coverage    60.51%   60.55%   +0.04%     
===========================================
  Files          519      519              
  Lines        36290    36298       +8     
===========================================
+ Hits         21961    21981      +20     
+ Misses       11160    11138      -22     
- Partials      3169     3179      +10     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 823f7c9 into develop Apr 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-spec-tests branch April 20, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants