Initialize Data Correctly For Powchain Service #8812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beacon-chain/powchain/service.go
Outdated
| return true | ||
| } | ||
| } | ||
| log.Infof("Recovering missing deposit containers, node is re-requesting missing deposit data.") |
There was a problem hiding this comment.
Suggested change
| log.Infof("Recovering missing deposit containers, node is re-requesting missing deposit data.") | |
| log.Info("Recovering missing deposit containers, node is re-requesting missing deposit data.") |
There was a problem hiding this comment.
Remove the period too. Thanks
rauljordan
reviewed
Apr 25, 2021
terencechain
approved these changes
Apr 25, 2021
prestonvanloon
approved these changes
Apr 25, 2021
prestonvanloon
pushed a commit
that referenced
this pull request
Apr 25, 2021
* initialize index correctly * comments * review comments * Update beacon-chain/powchain/service.go Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
| @@ -955,7 +955,7 @@ func (s *Service) initializeEth1Data(ctx context.Context, eth1DataInDB *protodb. | |||
| return nil | |||
| } | |||
|
|
|||
| // validates that all deposit containers are valid and have their relevant indexes | |||
| // validates that all deposit containers are valid and have their relevant indices | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Other notes for review