Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Validator Map Copies #8860

Merged
merged 4 commits into from
May 5, 2021
Merged

Remove Validator Map Copies #8860

merged 4 commits into from
May 5, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented May 4, 2021

What type of PR is this?

Feature Improvement

What does this PR do? Why is it needed?

  • Reverts back to our original behaviour to have a single map utilized by all shared states. This breaks the invariant that
    all state operations are restricted to the underlying state. However, given that we can handle indexes not in the current registry
    this edge case can be appropriately handled. The assumptions here are that deposit processing and ordering are fixed, so
    all validators will always be included in the same order.

Which issues(s) does this PR fix?

Replaces #8854

Other notes for review

@nisdas nisdas requested a review from a team as a code owner May 4, 2021 02:07
@nisdas nisdas requested review from farazdagi, kasey and 0xKiwi May 4, 2021 02:07
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #8860 (8454a3d) into develop (8dd2915) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #8860      +/-   ##
===========================================
- Coverage    60.71%   60.66%   -0.06%     
===========================================
  Files          527      527              
  Lines        37091    37090       -1     
===========================================
- Hits         22520    22499      -21     
- Misses       11335    11358      +23     
+ Partials      3236     3233       -3     

@nisdas nisdas merged commit 60c6cf7 into develop May 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the reduceValidatorMapCopies branch May 5, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants