Simplify handling hex state ID #8890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #8890 +/- ##
===========================================
+ Coverage 60.58% 60.75% +0.17%
===========================================
Files 527 527
Lines 37160 37154 -6
===========================================
+ Hits 22513 22574 +61
+ Misses 11417 11349 -68
- Partials 3230 3231 +1 |
terencechain
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Changes the way state API endpoints treat incoming hex values of state ID. Currently they assume hex values contain the
0xprefix, but since we receive a byte array it's more reasonable to send only the state ID. This change will make state endpoint behave in the same way as block endpoints.The
0xprefix will be removed by the HTTP proxy server before forwarding the request.Which issues(s) does this PR fix?
N/A
Other notes for review
N/A