Fix Interop Mode #8961
Merged
Fix Interop Mode #8961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #8961 +/- ##
===========================================
- Coverage 60.87% 60.84% -0.04%
===========================================
Files 530 530
Lines 37501 37698 +197
===========================================
+ Hits 22830 22936 +106
- Misses 11393 11472 +79
- Partials 3278 3290 +12 |
terencechain
reviewed
Jun 1, 2021
| numValsIsSet := cliCtx.IsSet(flags.InteropNumValidatorsFlag.Name) | ||
| votesIsSet := cliCtx.IsSet(flags.InteropMockEth1DataVotesFlag.Name) | ||
|
|
||
| if genStateIsSet || genTimeIsSet || numValsIsSet || votesIsSet { |
There was a problem hiding this comment.
Wouldn't this be genStateIsSet && genTimeIsSet && numValsIsSet && votesIsSet?
we need all four flags to apply for interop to work right?
There was a problem hiding this comment.
Nope anyone should be fine, technically all we need is just the correct genesis state.
terencechain
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
embedded genesis state.
Which issues(s) does this PR fix?
N.A
Other notes for review