Capture ChainReorg, FinalizedCheckpoint, and NewHead Events in Beacon Node #9011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure |
terencechain
requested changes
Jun 9, 2021
nisdas
reviewed
Jun 10, 2021
Codecov Report
@@ Coverage Diff @@
## develop #9011 +/- ##
===========================================
- Coverage 60.96% 60.89% -0.08%
===========================================
Files 531 531
Lines 37558 37611 +53
===========================================
+ Hits 22899 22902 +3
- Misses 11384 11432 +48
- Partials 3275 3277 +2 |
terencechain
approved these changes
Jun 10, 2021
| // Notifies a common event feed of a new chain head event. Called right after a new | ||
| // chain head is determined, set, and saved to disk. | ||
| func (s *Service) notifyNewHeadEvent( | ||
| newHeadSlot types.Slot, |
There was a problem hiding this comment.
Optional feedback:
These arguments could be cleaner and reduced... (ie. get slot from block, get state root from block... etc)
There was a problem hiding this comment.
I can fix in the next PR which integrates this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
As part of #9001, we need to capture a few important events in eth2 that are required for the eth/v1/events standard API endpoint. These include chain reorgs, finalized checkpoint, and new chain head.
IMPORTANT
The eth2.0-apis chain reorg event does not capture enough information about whether the reorg was across epoch boundaries. Currently, we have a
StreamDutiesendpoint that is UNUSED in Prysm which only resends duties if there is a reorg across epoch boundaries. Unfortunately, we can no longer tell this information and therefore we simply send the duties if there is a reorg at all. This should not be be very harmful as reorgs should be very rare and the endpoint is unused in v1alpha1.