Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Invert attest-timely flag" #9044

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Revert "Invert attest-timely flag" #9044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions shared/featureconfig/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,9 @@ func ConfigureValidator(ctx *cli.Context) {
log.WithField(disableAttestingHistoryDBCache.Name, disableAttestingHistoryDBCache.Usage).Warn(enabledFeatureFlag)
cfg.DisableAttestingHistoryDBCache = true
}
cfg.AttestTimely = true
if ctx.Bool(disableAttestTimely.Name) {
log.WithField(disableAttestTimely.Name, disableAttestTimely.Usage).Warn(enabledFeatureFlag)
cfg.AttestTimely = false
if ctx.Bool(attestTimely.Name) {
log.WithField(attestTimely.Name, attestTimely.Usage).Warn(enabledFeatureFlag)
cfg.AttestTimely = true
}
if ctx.Bool(enableSlashingProtectionPruning.Name) {
log.WithField(enableSlashingProtectionPruning.Name, enableSlashingProtectionPruning.Usage).Warn(enabledFeatureFlag)
Expand Down
6 changes: 0 additions & 6 deletions shared/featureconfig/deprecated_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ var (
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedAttestingTimely = &cli.BoolFlag{
Name: "attest-timely",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedProposerAttsSelectionUsingMaxCover = &cli.BoolFlag{
Name: "proposer-atts-selection-using-max-cover",
Usage: deprecatedUsage,
Expand All @@ -56,6 +51,5 @@ var deprecatedFlags = []cli.Flag{
deprecatedDisablePruningDepositProofs,
deprecatedDisableEth1DataMajorityVote,
deprecatedDisableBlst,
deprecatedAttestingTimely,
deprecatedProposerAttsSelectionUsingMaxCover,
}
8 changes: 4 additions & 4 deletions shared/featureconfig/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ var (
Name: "disable-broadcast-slashings",
Usage: "Disables broadcasting slashings submitted to the beacon node.",
}
disableAttestTimely = &cli.BoolFlag{
Name: "disable-attest-timely",
Usage: "Disable attest timely, a fix where validator can attest timely after current block processes. See #8185 for more details",
attestTimely = &cli.BoolFlag{
Name: "attest-timely",
Usage: "Fixes validator can attest timely after current block processes. See #8185 for more details",
}
enableNextSlotStateCache = &cli.BoolFlag{
Name: "enable-next-slot-state-cache",
Expand Down Expand Up @@ -144,7 +144,7 @@ var ValidatorFlags = append(deprecatedFlags, []cli.Flag{
Mainnet,
disableAccountsV2,
dynamicKeyReloadDebounceInterval,
disableAttestTimely,
attestTimely,
enableSlashingProtectionPruning,
}...)

Expand Down