Run text/event-stream values returned from grpc-gateway through API Middleware
#9080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # shared/gateway/gateway.go
Codecov Report
@@ Coverage Diff @@
## develop #9080 +/- ##
===========================================
- Coverage 60.28% 60.18% -0.11%
===========================================
Files 541 541
Lines 38648 38725 +77
===========================================
+ Hits 23300 23307 +7
- Misses 11996 12052 +56
- Partials 3352 3366 +14 |
rauljordan
previously approved these changes
Jun 24, 2021
rauljordan
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
What does this PR do? Why is it needed?
https://ethereum.github.io/eth2.0-APIs/#/Events/eventstream has been implemented on the gRPC server side and in grpc-gateway, but it has to be run through API Middleware to function correctly.
I made use of the client side of this library, which fully implements server-side events according to r3labs/sse#33 (comment).
Which issues(s) does this PR fix?
N/A
Other notes for review
N/A