Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposer sync contribution type #9106

Merged
merged 6 commits into from
Jun 28, 2021
Merged

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Jun 27, 2021

Part of #8638

Add proposer sync contribution type. Change list:

  • rename previous proposer_util.go to proposer_attestation.go
  • add proposerSyncContributions type
  • add filter method to filter by block root
  • add filter method to filter by sub committee index
  • add dedup method to filter by containment
  • add tests

@terencechain terencechain self-assigned this Jun 27, 2021
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #9106 (2c35cc8) into develop (0f2e6fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #9106   +/-   ##
========================================
  Coverage    60.23%   60.24%           
========================================
  Files          543      544    +1     
  Lines        38727    38755   +28     
========================================
+ Hits         23327    23347   +20     
- Misses       12036    12046   +10     
+ Partials      3364     3362    -2     

@terencechain terencechain marked this pull request as ready for review June 28, 2021 18:16
@terencechain terencechain requested a review from a team as a code owner June 28, 2021 18:16
@terencechain terencechain requested review from jmozah, rkapka and nisdas and removed request for a team June 28, 2021 18:16
@rauljordan rauljordan merged commit ea34af4 into develop Jun 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the proposer-sync-aggregate branch June 28, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants