Update Go-Ethereum #9157
Merged
Update Go-Ethereum #9157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
prestonvanloon,
terencechain and
rkapka
and removed request for
a team
|
Removing ready for review tag due to failng build. Please fix then request review. |
Codecov Report
@@ Coverage Diff @@
## develop #9157 +/- ##
===========================================
- Coverage 60.59% 60.54% -0.05%
===========================================
Files 544 544
Lines 38935 38937 +2
===========================================
- Hits 23591 23573 -18
- Misses 11882 11895 +13
- Partials 3462 3469 +7 |
prestonvanloon
approved these changes
Jul 9, 2021
| @@ -109,9 +109,13 @@ func main() { | |||
| if err != nil { | |||
| log.Fatal(err) | |||
| } | |||
| txOps = bind.NewKeyedTransactor(privKey) | |||
| txOps, err = bind.NewKeyedTransactorWithChainID(privKey, big.NewInt(1337)) | |||
There was a problem hiding this comment.
Seems like this will not work on any chain besides 1337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix, Dependency Update
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N.A
Other notes for review