Prevent Reinsertion of Orphaned Attestations Into Pool #9442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested review from
rauljordan,
prestonvanloon and
nisdas
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #9442 +/- ##
===========================================
+ Coverage 60.41% 60.92% +0.50%
===========================================
Files 581 581
Lines 42830 42915 +85
===========================================
+ Hits 25877 26146 +269
+ Misses 13054 12804 -250
- Partials 3899 3965 +66 |
prestonvanloon
requested changes
Aug 23, 2021
prestonvanloon
previously approved these changes
Aug 23, 2021
rauljordan
changed the title
rauljordan
reviewed
Aug 23, 2021
beacon-chain/blockchain/head.go
Outdated
| @@ -143,6 +144,12 @@ func (s *Service) saveHead(ctx context.Context, headRoot [32]byte) error { | |||
| }, | |||
| }) | |||
|
|
|||
| if featureconfig.Get().CorrectlyInsertOrphanedAtts { | |||
There was a problem hiding this comment.
Let's move this inside of the saveOrphanedAtts function so that callers dont need to keep track of feature flags
rauljordan
approved these changes
Aug 23, 2021
rauljordan
previously approved these changes
Aug 23, 2021
rauljordan
approved these changes
Aug 24, 2021
prestonvanloon
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Can re-save orphaned attestation * Go fmt * Fix tests * Go fmt * Bug fix flag * Bug fix flag * Go fmt Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> (cherry picked from commit 5c96a27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9441
This ensures we can re-insert orphaned attestations back to the attestation pool for later inclusion into beacon block. Attestation that is one epoch old will get filtered out