Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring Eth2FastAggregateVerify Inline With the Spec #9742

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Bring Eth2FastAggregateVerify Inline With the Spec #9742

merged 2 commits into from
Oct 6, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Oct 6, 2021 •
edited
Loading

What type of PR is this?

Security Cleanup

What does this PR do? Why is it needed?

  • Remove innerFastAggregateVerify and instead simply call FastAggregateVerify to be inline with the spec more closely. This results in an extra call to check SkipBLSVerify , but it is fine for the current case.

Which issues(s) does this PR fix?

Fixes #9737

Other notes for review

@nisdas nisdas added Ready For Review Security Security Related Issues labels Oct 6, 2021
@nisdas nisdas requested a review from a team as a code owner October 6, 2021 00:36
@nisdas nisdas requested review from kasey, jmozah and rauljordan October 6, 2021 00:36
@nisdas nisdas changed the title Check For Empty Pubkey List Make Eth2FastAggregateVerify More Inline With the Spec Oct 6, 2021
@nisdas nisdas changed the title Make Eth2FastAggregateVerify More Inline With the Spec Bring Eth2FastAggregateVerify Inline With the Spec Oct 6, 2021
@nisdas nisdas mentioned this pull request Oct 6, 2021
Closed
@nisdas nisdas merged commit b128d44 into develop Oct 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the checkLength branch October 6, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@jmozah jmozah Awaiting requested review from jmozah jmozah is a code owner automatically assigned from prysmaticlabs/core-team

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Security Security Related Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No length check on pubKeys in Eth2FastAggregateVerify
2 participants
@nisdas @prestonvanloon