Validate Keystores Validator Client RPC Endpoint #9799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Oct 19, 2021
| @@ -26,14 +26,15 @@ service Wallet { | |||
| get: "/v2/validator/wallet" | |||
| }; | |||
| } | |||
| rpc GenerateMnemonic(google.protobuf.Empty) returns (GenerateMnemonicResponse) { | |||
There was a problem hiding this comment.
This is unused and no plans to ever bring it back
rkapka
approved these changes
Oct 19, 2021
| Mnemonic: mnemonic, | ||
| }, nil | ||
| // Needs to unmarshal the keystores from the requests. | ||
| if req.Keystores == nil || len(req.Keystores) < 1 { |
There was a problem hiding this comment.
In such cases I always wonder if we should be even more restrictive and:
- check if at least one value in the array is not empty (or has whitespace only)
- in the loop that follows, skip empty/whitespace values
This might be too defensive though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the web UI onboarding, it is important to validate if a user's password can decrypt the keystores they provided during the wizard steps. Otherwise, we complete the entire onboarding process only for a user to be met with an "Incorrect keystore password" error that could have been avoided.