Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify should update justified #9837

Merged
merged 8 commits into from
Nov 3, 2021
Merged

Simplify should update justified #9837

merged 8 commits into from
Nov 3, 2021

Conversation

terencechain
Copy link
Member

This PR simplifies should_update_justified_checkpoint method to align with the spec. The previous implementation contains a few unnecessary checks and should be removed. I've also added the python spec code for cross reference

@terencechain terencechain self-assigned this Oct 29, 2021
@terencechain terencechain requested a review from a team as a code owner October 29, 2021 16:49
rkapka
rkapka previously approved these changes Nov 1, 2021
View reviewed changes
nisdas
nisdas previously approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would having these sanity checks here be a burden ? They are defensive in the event we have some improbable situation where the justified block doesn't exist in the db/cache.

@nisdas nisdas dismissed their stale review November 1, 2021 10:40

wrong one

rauljordan
rauljordan previously approved these changes Nov 1, 2021
View reviewed changes
@prestonvanloon
Copy link
Member

Tests fail consistently for nil pointer.

@terencechain terencechain dismissed stale reviews from rauljordan and rkapka via 6e269fc November 2, 2021 16:43
@prylabs-bulldozer prylabs-bulldozer bot merged commit 2ea09b6 into develop Nov 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the simplyfy-should-update-justified branch November 3, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@nisdas nisdas nisdas left review comments

@rauljordan rauljordan rauljordan left review comments

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@jmozah jmozah Awaiting requested review from jmozah jmozah is a code owner automatically assigned from prysmaticlabs/core-team

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terencechain @prestonvanloon @rauljordan @rkapka @nisdas