Add in Deposit Map To Cache #9885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +53,7 @@ type DepositCache struct { | |||
| pendingDeposits []*dbpb.DepositContainer | |||
| deposits []*dbpb.DepositContainer | |||
| finalizedDeposits *FinalizedDeposits | |||
| depositMap map[[48]byte][]*dbpb.DepositContainer | |||
There was a problem hiding this comment.
I will argue that if we always only going to return the first deposit, we dont need a list for value. But i think extensibility is nice, maybe we'll need DepositsByPubkey one day
rauljordan
reviewed
Nov 15, 2021
| @@ -54,6 +53,7 @@ type DepositCache struct { | |||
| pendingDeposits []*dbpb.DepositContainer | |||
| deposits []*dbpb.DepositContainer | |||
| finalizedDeposits *FinalizedDeposits | |||
| depositMap map[[48]byte][]*dbpb.DepositContainer | |||
There was a problem hiding this comment.
We tend to avoid giving variables names related to their type in Go. This doesn't tell us much about what the keys in the map are, so maybe we can call it depositsByPubKey
rauljordan
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
For our validator rpc methods, a lot of them require knowledge on a particular validator's deposit. If the validator
isn't active yet we have to perform a large search through all our deposits. Adding a map brings this down to
O(1)fromO(n)per validator.Fix and add relevant tests.
Which issues(s) does this PR fix?
N.A
Other notes for review