-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitor attestations #9901
Merged
Merged
Monitor attestations #9901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
force-pushed
the
monitor_attestations
branch
2 times, most recently
from
November 13, 2021 21:30
2f3ebad
to
28c90c9
Compare
potuz
force-pushed
the
monitor_attestations
branch
2 times, most recently
from
November 15, 2021 17:21
50c24b7
to
b4e3494
Compare
potuz
force-pushed
the
monitor_attestations
branch
from
November 15, 2021 20:41
b4e3494
to
f8ccb39
Compare
terencechain
requested changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 First round of feedbacks. Will look again
potuz
force-pushed
the
monitor_attestations
branch
from
November 16, 2021 18:23
c65c2f7
to
5a9e150
Compare
potuz
force-pushed
the
monitor_attestations
branch
from
November 16, 2021 18:29
5a9e150
to
f3d88f8
Compare
prestonvanloon
requested changes
Nov 16, 2021
terencechain
previously approved these changes
Nov 18, 2021
prestonvanloon
approved these changes
Nov 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the third in the implementation of the validator monitor, it should be reviewed after #9899
This PR implements logging of performance for attestations viewed by our tracked validators. For attestations included in blocks it logs
In addition to the basic information
For unagregated and aggregated attestations processed by the node (after P2P validation but not necessarily included in a block), we log only the basic information above.
In addition, for P2P aggregated attestations, we log the event that one of our tracked validators was the aggregator.
The P2P logging (namely not included in blocks) is only performed if the appropriate Beacon State is currently cached to avoid expensive lookups. This requires addition of the appropriate function in the stategen package.
info for reviewers