Prevent Reprocessing of a Block From Our Pending Queue #9904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail |
|
Good catch on the |
rauljordan
reviewed
Nov 17, 2021
| if err := s.deleteBlockFromPendingQueue(slot, b, blkRoot); err != nil { | ||
| return err | ||
| } | ||
| s.pendingQueueLock.Unlock() |
There was a problem hiding this comment.
you need to release the lock if there's an error in the line above as well
There was a problem hiding this comment.
Ah , very nice catch. We use the same pattern in a few places, will fix them.
rauljordan
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N.A
Other notes for review